Bump christophwurst/id3parser to 0.1.4 #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Nov 29, 2021
st3iny
approved these changes
Nov 29, 2021
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/bump-christophwurst/id3parser-to-0.1.4
branch
from
6a7b6be to
1f50b25
Compare
|
Hi! Could this be backported to |
|
What would be the benefits of the backport? |
|
Without the backport https://github.com/nextcloud/previewgenerator throws errors when using PHP 8.x, which is supported by nextcloud 21 & 22. More info: nextcloud/previewgenerator#249 |
|
so, how can this be done @ChristophWurst ? |
✌️ |
This was referenced Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com
Needed for PHP 8.1 compatibility
Replaces #935