Skip to content

[stable22]: Add composer patch#890

Merged
CarlSchwan merged 1 commit intostable22from
work/composer-patch-stable22
Nov 15, 2021
Merged

[stable22]: Add composer patch#890
CarlSchwan merged 1 commit intostable22from
work/composer-patch-stable22

Conversation

@CarlSchwan
Copy link
Member

This might be helpful later and unify the handling with master

Signed-off-by: Carl Schwan carl@carlschwan.eu

@nickvergessen
Copy link
Member

Conflicts with https://github.com/nextcloud/3rdparty/blob/stable22/patches.txt ? or well should we add them all to make sure they are applied correctly?

@CarlSchwan
Copy link
Member Author

Conflicts with https://github.com/nextcloud/3rdparty/blob/stable22/patches.txt ? or well should we add them all to make sure they are applied correctly?

Unfortunately, It seems this list of patches isn't getting applied for a while now :( And I'm not completely sure if we should try to apply them again or just remove that list and consider it as outdated.

@CarlSchwan
Copy link
Member Author

I took a look at the patches listed in the file. These are the one who didn't get merged:

@CarlSchwan CarlSchwan force-pushed the work/composer-patch-stable22 branch from 7626427 to 3fc1b65 Compare November 15, 2021 12:28
@nickvergessen
Copy link
Member

@nickvergessen
Copy link
Member

Fix like escape for sqlite doctrine/dbal#3104

When this is still applied in our code base we should add the patch as well, so it is reapplied on every update.
Otherwise good to go

This might be helpful later and unify the handling with master

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the work/composer-patch-stable22 branch from 3fc1b65 to bac387e Compare November 15, 2021 15:20
@CarlSchwan CarlSchwan merged commit ca58d28 into stable22 Nov 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the work/composer-patch-stable22 branch November 15, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants