Skip to content

chore(libphonenumber): Bump giggsey/libphonenumber-for-php to giggsey… #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
May 31, 2023
Merged

chore(libphonenumber): Bump giggsey/libphonenumber-for-php to giggsey… #1421

nickvergessen merged 1 commit into from
May 31, 2023

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 30, 2023 •
edited
Loading

…/libphonenumber-for-php-lite

https://github.com/giggsey/libphonenumber-for-php#giggseylibphonenumber-for-php-lite

If you only want to make sure of the core PhoneNumber Util functionality, you can use giggsey/libphonenumber-for-php-lite, which offers a much smaller package size.

  • Less dependencies and bumped to latest version

@nickvergessen nickvergessen added this to the Nextcloud 28 milestone May 30, 2023
@nickvergessen nickvergessen requested a review from come-nc May 30, 2023 12:20
@nickvergessen nickvergessen self-assigned this May 30, 2023
@nickvergessen nickvergessen mentioned this pull request May 30, 2023
Merged
4 tasks
@nickvergessen
chore(libphonenumber): Bump giggsey/libphonenumber-for-php to giggsey…
ef103ad 
…/libphonenumber-for-php-lite

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bump/giggsey/libphonenumber-for-php_to_lite-version branch from f9e72a2 to ef103ad Compare May 30, 2023 14:15
@nickvergessen
Copy link
Member Author

nickvergessen commented May 30, 2023

Rebased after #1422

@nickvergessen nickvergessen merged commit 216b791 into master May 31, 2023
@nickvergessen nickvergessen deleted the bump/giggsey/libphonenumber-for-php_to_lite-version branch May 31, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@nickvergessen nickvergessen

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @ChristophWurst @kesselb