Bump PHP to 8.0 - #1215
Merged
Merged
Conversation
1 task
come-nc
force-pushed
the
fix/drop-php-7.4
branch
2 times, most recently
from
December 12, 2022 11:30
bb4871b to
d8747e3
Compare
come-nc
marked this pull request as ready for review
December 12, 2022 11:31
nickvergessen
approved these changes
Dec 12, 2022
come-nc
force-pushed
the
fix/drop-php-7.4
branch
from
January 5, 2023 13:54
d8747e3 to
e2a27fe
Compare
Contributor
Author
|
Rebased |
come-nc
force-pushed
the
fix/drop-php-7.4
branch
from
January 16, 2023 10:09
e2a27fe to
b860c0e
Compare
Contributor
Author
|
Rebased |
ChristophWurst
requested changes
Jan 18, 2023
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Changes in php-opencloud/openstack are unrelated
Member
|
That happened because most numbers are "fixed" with |
Member
|
if you change composer.json and run |
Contributor
Author
This is what I did. |
Contributor
Author
Actually I remembered wrong, I did what you said and had: Which is why I also updated this lib. |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/drop-php-7.4
branch
from
January 20, 2023 10:12
b860c0e to
5dfa6a9
Compare
Contributor
Author
|
Rebuilt on top of master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop 7.4 on master
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com