Skip to content

Bump PHP to 8.0 - #1215

Merged
come-nc merged 1 commit into
masterfrom
fix/drop-php-7.4
Jan 20, 2023
Merged

Bump PHP to 8.0#1215
come-nc merged 1 commit into
masterfrom
fix/drop-php-7.4

Conversation

@come-nc

@come-nc come-nc commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Drop 7.4 on master

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc self-assigned this Nov 7, 2022
@come-nc
come-nc force-pushed the fix/drop-php-7.4 branch 2 times, most recently from bb4871b to d8747e3 Compare December 12, 2022 11:30
@come-nc
come-nc marked this pull request as ready for review December 12, 2022 11:31
@come-nc

come-nc commented Jan 5, 2023

Copy link
Copy Markdown
Contributor Author

Rebased

@come-nc

come-nc commented Jan 16, 2023

Copy link
Copy Markdown
Contributor Author

Rebased

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in php-opencloud/openstack are unrelated

@nickvergessen

Copy link
Copy Markdown
Member

That happened because most numbers are "fixed" with ^X.Y instead of ^X.Y.Z which means it also installs any X.(Y+1) so it updated 3.1.z to 3.2.a because that now works as 8.0 is the minimum....

@ChristophWurst

Copy link
Copy Markdown
Member

if you change composer.json and run composer update php no other deps should be touched

@come-nc

come-nc commented Jan 20, 2023

Copy link
Copy Markdown
Contributor Author

if you change composer.json and run composer update php no other deps should be touched

This is what I did.

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘 then

@come-nc

come-nc commented Jan 20, 2023

Copy link
Copy Markdown
Contributor Author

elephant then

Actually I remembered wrong, I did what you said and had:

> composer update php --no-dev
Gathering patches from patch file.
No patches supplied.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - php-opencloud/openstack is locked to version v3.1.0 and an update of this package was not requested.
    - php-opencloud/openstack v3.1.0 requires php ^7.2.5 -> your php version (8.0; overridden via config.platform, actual: 8.1.2) does not satisfy that requirement.

Which is why I also updated this lib.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc

come-nc commented Jan 20, 2023

Copy link
Copy Markdown
Contributor Author

Rebuilt on top of master

@come-nc
come-nc merged commit 1d53ed4 into master Jan 20, 2023
@come-nc
come-nc deleted the fix/drop-php-7.4 branch January 20, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants