Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 6, 2025

Allow the config to be used with Nextcloud 31 (Node 20), Nextcloud 32 (Node 22) and upcoming Nextcloud 33, 34, 35 (Node 24). Added devEngines to have consistent developer experience.

Best to first merge #694

Allow the config to be used with Nextcloud 31 (Node 20),
Nextcloud 32 (Node 22) and upcoming Nextcloud 33, 34, 35 (Node 24).
Added `devEngines` to have consistent developer experience.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested review from ShGKme and artonge November 6, 2025 17:09
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it so bad if we don't have the exacte same version of node and npm?

@susnux
Copy link
Contributor Author

susnux commented Nov 6, 2025

Why is it so bad if we don't have the exacte same version of node and npm?

Its not bad to not have the same exact version, but the major version should be the same.
As there are sometimes differences in e.g. how modules are resolved by npm causing different package-lock.
Or changes that make test fail and are otherwise not spotted (e.g. ci versus locally)

@susnux susnux merged commit ed6f6db into main Nov 6, 2025
6 checks passed
@susnux susnux deleted the chore/dev-engines branch November 6, 2025 18:40
@susnux susnux mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants