fix: ignore ./locale
import from moment/min/moment-with-locales
#533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compatibility between
@nextcloud/webpack-vue-config
and@nextcloud/moment@1.3.0
(since migration to Vite).@nextcloud/moment
usesmoment/min/moment-with-locales.js
, which works only in Node.js and is not compatible with Webpack bundling. It has an unused functionlocalLocale
that requires locales by invalid relative path./locale
. Though it is not used, Webpack tries to resolve it withrequire.context
and fails.Example of issue in Talk, same in Text and other apps:
See also:
@nextcloud/moment
: https://github.com/nextcloud-libraries/nextcloud-moment/blob/c73f43f7e7713a92bad98251aad22b3cd57a757e/lib/index.ts#L1moment/min/moment-with-locales.js
: https://github.com/moment/moment/blob/develop/min/moment-with-locales.js#L2159