Skip to content

feat: add OC_Helper rule for computerFileSize and humanFileSize methods #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
May 14, 2025
Merged

feat: add OC_Helper rule for computerFileSize and humanFileSize methods #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions config/nextcloud-25/nextcloud-25-deprecations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,22 @@
use Nextcloud\Rector\Rector\OcpUtilAddScriptRector;
use Nextcloud\Rector\ValueObject\LegacyGetterToOcpServerGet;
use Rector\Config\RectorConfig;
use Rector\Renaming\Rector\StaticCall\RenameStaticMethodRector;
use Rector\Renaming\ValueObject\RenameStaticMethod;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->rules([
OcServerToOcpServerRector::class,
OcpUtilAddScriptRector::class,
]);

$rectorConfig->ruleWithConfiguration(RenameStaticMethodRector::class, [
// Deprecated since 4.0.0
new RenameStaticMethod('OC_Helper', 'computerFileSize', 'OCP\Util', 'computerFileSize'),
// Deprecated since 4.0.0
new RenameStaticMethod('OC_Helper', 'humanFileSize', 'OCP\Util', 'humanFileSize'),
]);

$rectorConfig->ruleWithConfiguration(
LegacyGetterToOcpServerGetRector::class,
[
Expand Down
33 changes: 33 additions & 0 deletions tests/Set/Fixture/test_fixture_oc_helper.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?php

namespace Nextcloud\Rector\Test\Set\Fixture;

class SomeClass
{
public function foo()
{
$size = \OC_Helper::humanFileSize(1223);
$size2 = \OC_Helper::computerFileSize('12 KB');
$size3 = \OC_Helper::humanFileSize($size2);
$size2 = \OC_Helper::computerFileSize($size);
}
}

?>
-----
<?php

namespace Nextcloud\Rector\Test\Set\Fixture;

class SomeClass
{
public function foo()
{
$size = \OCP\Util::humanFileSize(1223);
$size2 = \OCP\Util::computerFileSize('12 KB');
$size3 = \OCP\Util::humanFileSize($size2);
$size2 = \OCP\Util::computerFileSize($size);
}
}

?>