fix(NcInputField): use overflow-wrap: anywhere instead of word-break: break-all for the helper text#8225
Open
Sector6759 wants to merge 1 commit intonextcloud-libraries:mainfrom
Conversation
…ak: break-all` for the helper text Signed-off-by: Sector6759 <149817326+Sector6759@users.noreply.github.com>
Sector6759
force-pushed
the
input-field-helper-text-wrapping
branch
from
4b357a2 to
ed7c046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #8128 introduced a new bug when it tried to fix another one. The PR added
word-break: break-all;to the helper text, preventing long unbreakable URLs from overflowing the container, but this now leads to any word being broken into multiple lines, even if the word where the line break occurs would itself fit into the container. This new PR instead usesoverflow-wrap: anywhere;which appears to be fine for any text. The only "downside", if you'd want to call it that, is that Firefox and Chrome insert the line break at different positions when encountering a long URL, as you can see in the second set of screenshots.🖼️ Screenshots
"Normal" text
Long unbreakable URL
🏁 Checklist
stable8for maintained Vue 2 version or not applicable