Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix component appearance
    • 'fake' preloaded user status can be provided, but it should not be limited to 'users' only, (e.g. there can be federated users and guests having it in the future)
    • avatar should not be requested by url from server, if <slot #icon> is provided by app and therefore won't be ever shown

🖼️ Screenshots

image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added this to the 9.3.0 milestone Nov 19, 2025
@Antreesy Antreesy self-assigned this Nov 19, 2025
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Nov 19, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Nov 19, 2025

fix(NcAvatar): do no request avatar image if icon slot provided

Most of the changes are not related to the PR title (release note) 👀

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, the next time split into 2 PRs for 2 independent changes, or do not forget to manually adjust the changelog

@Antreesy
Copy link
Contributor Author

/backport to stable8

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@ShGKme ShGKme force-pushed the fix/noid/nc-avatar branch from 8d744f9 to 121badd Compare November 20, 2025 11:34
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.14%. Comparing base (0074857) to head (121badd).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/components/NcAvatar/NcAvatar.vue 75.00% 1 Missing ⚠️
src/mixins/userStatus.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7891      +/-   ##
==========================================
+ Coverage   52.11%   52.14%   +0.03%     
==========================================
  Files         100      100              
  Lines        3170     3170              
  Branches      872      871       -1     
==========================================
+ Hits         1652     1653       +1     
  Misses       1271     1271              
+ Partials      247      246       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme enabled auto-merge November 20, 2025 11:37
@ShGKme ShGKme merged commit 07a83b7 into main Nov 20, 2025
27 checks passed
@ShGKme ShGKme deleted the fix/noid/nc-avatar branch November 20, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants