-
Notifications
You must be signed in to change notification settings - Fork 95
fix(NcAvatar): do no request avatar image if icon slot provided #7891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most of the changes are not related to the PR title (release note) 👀 |
ShGKme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, the next time split into 2 PRs for 2 independent changes, or do not forget to manually adjust the changelog
bfd903c to
8d744f9
Compare
|
/backport to stable8 |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
8d744f9 to
121badd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7891 +/- ##
==========================================
+ Coverage 52.11% 52.14% +0.03%
==========================================
Files 100 100
Lines 3170 3170
Branches 872 871 -1
==========================================
+ Hits 1652 1653 +1
Misses 1271 1271
+ Partials 247 246 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
☑️ Resolves
<slot #icon>is provided by app and therefore won't be ever shown🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable