Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 7, 2025

☑️ Resolves

  • Fix performance issues with active/massive NcListItems rendering with (unforced) actions
  • Only render NcActions when needed instead of hidding visually
  • I checked the history and did not found any specific reason to use v-show, it looks like that's just how it used to be
  • Works with keyboard, focus, mouse over etc. (not worse than in the past)

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme self-assigned this Nov 7, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Nov 7, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 7, 2025

/backport to stable8

@ShGKme ShGKme enabled auto-merge November 7, 2025 14:40
@ShGKme ShGKme added this to the 9.2.0 milestone Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.41%. Comparing base (58175c1) to head (57dd7bc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7817   +/-   ##
=======================================
  Coverage   51.41%   51.41%           
=======================================
  Files          96       96           
  Lines        3147     3147           
  Branches      868      867    -1     
=======================================
  Hits         1618     1618           
  Misses       1279     1279           
  Partials      250      250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ShGKme ShGKme merged commit f0c9eaa into main Nov 7, 2025
27 checks passed
@ShGKme ShGKme deleted the fix/NcListItem-render-actions-lazy branch November 7, 2025 14:43
@ShGKme ShGKme mentioned this pull request Nov 7, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 9, 2025

This change has a regression in the opposite way - now hovering NcListItems is a bit slower. Noticed it on battery safe mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants