fix(NcHotkeyList): align with form labels

[ShGKme]

☑️ Resolves

• The offset was changed between NcHotkeyList and other components implementation
• Follow-up: share the CSS variable (somehow)

🖼️ Screenshots

🏚️ Before	🏡 After

🏁 Checklist

• ⛑️ Tests are included or are not applicable
• 📘 Component documentation has been extended, updated or is not applicable
• 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.58%. Comparing base (d21cce6) to head (c96fa79).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7807   +/-   ##
=======================================
  Coverage   51.58%   51.58%           
=======================================
  Files          96       96           
  Lines        3148     3148           
  Branches      866      866           
=======================================
  Hits         1624     1624           
  Misses       1276     1276           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[susnux]

unrelated but it looks a bit weird that the shortcuts are not fully expanded (width)

[kra-mo]

unrelated but it looks a bit weird that the shortcuts are not fully expanded (width)

I agree. If we're not gonna limit the width of the rest for now, maybe it's best to not limit the width of the shortcuts either.

[ShGKme]

unrelated but it looks a bit weird that the shortcuts are not fully expanded (width)

Comes from the design

I agree

That was your request 🥲

[susnux]

I agree. If we're not gonna limit the width of the rest for now, maybe it's best to not limit the width of the shortcuts either.

IMHO limiting the width looks weird, the content should use the full width of the dialog.
If we want to have it tighter then we should decrease the dialog and not introduce empty space on the side, no?

[susnux]

/backport to stable8

[ShGKme]

If we want to have it tighter then we should decrease the dialog and not introduce empty space on the side, no?

We use NcDialog, which has a predefined size including navigation. And which then uses NcModal with predefined sizes.

To have a single dialog in a specific width, we need more than a size setting.

[susnux]

To have a single dialog in a specific width, we need more than a size setting.

Well basically thats where the presets come from: Usage.
If we decide the normal dialog needs to be tighter (this usage here) then the preset is basically to be adjusted.
Otherwise we end with a bunch of randomly sized dialogs.

[ShGKme]

If we decide the normal dialog needs to be tighter (this usage here) then the preset is basically to be adjusted.

And if we decide that every normal dialog is the settigns dialog

[kra-mo]

That was your request 🥲

Yeah, sorry, I do eventually want to limit the width, but definitely of the entire form together. Doing it as a one-off maybe isn't the best.

I mean it's not too bad as it stands, and it fixes the issue of the labels being too far apart from the keys (as here it does matter, since they are not clickable) but I do agree that it looks weird.

I think we need to discuss what to do exactly. I do think limiting the dialog width further would probably be the best though.

[kra-mo]

For what it's worth, variable dialog widths are common across design systems as well. Not everything necessarily needs to adhere to a single size.