Skip to content

fix(NcFormGroup): remove margin when no label/description #7764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

fix(NcFormGroup): remove margin when no label/description #7764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions src/components/NcFormGroup/NcFormGroup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,18 @@ const slots = defineSlots<{
}>()

const id = `nc-form-group-${createElementId()}`
const labelId = `${id}-label`
const descriptionId = `${id}-description`

const hasDescription = () => !!description || !!slots.description
const getDescriptionId = () => hasDescription() ? descriptionId : undefined
const hasContentOnly = () => hideLabel && (!hasDescription() || hideDescription)
</script>

<template>
<fieldset
:class="[$style.formGroup, { [$style.formGroup_noGap]: noGap }]"
:aria-describedby="getDescriptionId()">
<legend :id="labelId" :class="[$style.formGroup__label, { 'hidden-visually': hideLabel }]">
<legend :class="[$style.formGroup__label, { 'hidden-visually': hideLabel }]">
<slot name="label">
{{ label || '⚠️ Missing label' }}
</slot>
Expand All @@ -74,7 +74,7 @@ const getDescriptionId = () => hasDescription() ? descriptionId : undefined
{{ description }}
</slot>
</div>
<div :class="$style.formGroup__content">
<div :class="[$style.formGroup__content, { [$style.formGroup__content_only]: hasContentOnly() }]">
<slot />
</div>
</fieldset>
Expand Down Expand Up @@ -106,8 +106,7 @@ const getDescriptionId = () => hasDescription() ? descriptionId : undefined
flex-direction: column;
gap: var(--form-group-content-gap);
margin-block-start: calc(4 * var(--default-grid-baseline));

&:first-child {
&.formGroup__content_only {
margin-block-start: 0;
}
}
Expand Down Expand Up @@ -137,4 +136,22 @@ Labelled group of form elements.
</NcFormGroup>
</template>
```

### Hidden label/description

You can visually hide the label and/or the description.\
Note: you still must provide the label. Do not visually hide the missing label warning!

```vue
<template>
<NcFormGroup
label="Personal information"
description="Your contact details"
hide-label
hide-description>
<NcTextField label="First name" />
<NcTextField label="Last name" />
</NcFormGroup>
</template>
```
</docs>
Loading