chore!: deprecate and remove NcSettingsInputText component
#7486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
force-pushed
the
chore/deprecate-nc-settings-input-text
branch
from
58395ed to
1fa2439
Compare
Antreesy
approved these changes
Sep 10, 2025
ShGKme
reviewed
Sep 10, 2025
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Since v9 is still on rc, let's deprecate it in v8 and remove it in v9?
Contributor
|
yeah, doesn't look like somebody's using it, at least within the org: https://github.com/search?q=org%3Anextcloud+NcSettingsInputText&type=code |
It is no longer used by Nextcloud or Nextcloud apps and not recommended to be used for design reasons. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/deprecate-nc-settings-input-text
branch
from
1fa2439 to
9c2c930
Compare
Contributor
Author
|
/backport 08cb210 to stable8 |
Contributor
Author
|
@ShGKme done! |
susnux
changed the title
NcSettingsInputText componentNcSettingsInputText component
ShGKme
approved these changes
Sep 10, 2025
Comment on lines
+457
to
+461
| ## [v8.31.0](https://github.com/nextcloud-libraries/nextcloud-vue/tree/v8.31.0) (unreleased) | ||
| ### 📝 Notes | ||
| The `NcSettingsInputText` component was deprecated, | ||
| it is no longer used by Nextcloud or Nextcloud apps and not recommended to be used for design reasons. | ||
|
|
Contributor
There was a problem hiding this comment.
Seem not relevant for a main branch, as v8 changelog will be changed on stable8.
Contributor
There was a problem hiding this comment.
I'm copying it back for 9rc releases, so fine
Contributor
Author
There was a problem hiding this comment.
yes during RC phase we sync them between v8 and v9. So its here for the backport and later then we sync 8.31 anyways ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
It is no longer used by Nextcloud or Nextcloud apps and not recommended to be used for design reasons.
🏁 Checklist
stable8for maintained Vue 2 version or not applicable