Skip to content

feat(NcFieldset): new component to structure settings #7352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(NcFieldset): new component to structure settings #7352

wants to merge 3 commits into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 21, 2025

☑️ Resolves

🖼️ Screenshots

Screenshot 2025-08-21 at 23-22-52 Nextcloud Vue Style Guide

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

susnux added 3 commits August 21, 2025 23:17
@susnux
feat(NcFieldset): provide a fieldset compomnent to be used in settings
3f2b80c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat(NcButton): support being mounted in NcFieldset
6f38ffd 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
feat(NcCheckboxRadioSwitch): allow being mounted in NcFieldset
36753a8 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the 9.0.0 milestone Aug 21, 2025
@susnux susnux added enhancement New feature or request 2. developing Work in progress component Component discussion and/or suggestion design Design, UX, interface and interaction design labels Aug 21, 2025
@jancborchardt jancborchardt mentioned this pull request Aug 26, 2025
Merged
jancborchardt
jancborchardt reviewed Aug 26, 2025
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably have it on your radar, just to make sure: A detail from the original mockup is that the grouped elements have an inner border-radius that is not completely 0 (but not as big as the outer radius):

Image

@Antreesy Antreesy modified the milestones: 9.0.0, 9.0.0-rc.10 Sep 11, 2025
@Antreesy Antreesy modified the milestones: 9.0.0-rc.10, 9.0.1 Oct 1, 2025
@susnux susnux modified the milestones: 9.0.1, 9.0.2 Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

2. developing Work in progress component Component discussion and/or suggestion design Design, UX, interface and interaction design enhancement New feature or request

Projects

None yet

Milestone

9.0.2

Development

Successfully merging this pull request may close these issues.

Add <NcFieldset> component

3 participants

@susnux @jancborchardt @Antreesy