Skip to content

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Aug 18, 2025

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD GretaD self-assigned this Aug 18, 2025
@GretaD GretaD added enhancement New feature or request 3. to review Waiting for reviews labels Aug 18, 2025
@Antreesy
Copy link
Contributor

IIRC the discussion was to change Cog not to outline, but to Material symbol: https://fonts.google.com/icons?icon.set=Material+Symbols&icon.size=24&icon.color=%235f6368&selected=Material+Symbols+Outlined:settings:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=cog
image

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for main, for backport it needs a legacy fallback

@susnux
Copy link
Contributor

susnux commented Aug 18, 2025

IIRC the discussion was to change Cog not to outline, but to Material symbol

As long as we do not have nextcloud/standards#16 or similar we should still use MDI for consistency and also for common dependencies.
So yes the stretch goal is Material Symbols but as we do not have a library to use we still use MDI

@GretaD GretaD merged commit e5e3892 into main Aug 18, 2025
25 checks passed
@GretaD GretaD deleted the feat/outline-icon branch August 18, 2025 13:01
@susnux
Copy link
Contributor

susnux commented Aug 18, 2025

/backport to stable8

@backportbot
Copy link

backportbot bot commented Aug 18, 2025

The backport to stable8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8
git pull origin stable8

# Create the new backport branch
git checkout -b backport/7299/stable8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 41a4b18e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7299/stable8

Error: Failed to check for changes with origin/stable8: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@Antreesy Antreesy mentioned this pull request Aug 19, 2025
@Antreesy Antreesy changed the title feat: change cob icon into the outline version feat: change icon cog into the outline version Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants