Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Jul 29, 2025

Backport of #7218

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Nextcloud 31- Nextcloud 32+
image image
image image
image image

@backportbot backportbot bot added 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Jul 29, 2025
@backportbot backportbot bot added this to the 8.29.0 milestone Jul 29, 2025
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/7218/stable8 branch from 6026fa6 to 2c1b1f9 Compare July 29, 2025 19:32
Antreesy
Antreesy approved these changes Jul 29, 2025
@Antreesy Antreesy marked this pull request as ready for review July 29, 2025 19:34
@nickvergessen
Copy link
Contributor

How complicated would it be to read a capability/template var or something to not use these icons on old Server?
I think it would be helpful to not mix them creating inconsistance with clients?

@ShGKme
Copy link
Contributor

ShGKme commented Jul 29, 2025

How complicated would it be to read a capability/template var or something to not use these icons on old Server? I think it would be helpful to not mix them creating inconsistance with clients?

IMO, the change is not so dramatic to consider it a problem, especially if this is about different icons on different clients and not different parts of a single page.

We can provide icons via server-defined CSS variables to make sure they are the same everywhere.

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we did similar in the past also for old server - so should be fine

@nickvergessen
Copy link
Contributor

especially if this is about different icons on different clients and not different parts of a single page.

You will see things in the calendar, mail and a lot of other apps that support multiple versions, before you can see it for yourself in the top right and it spills the refreshing redesign to old versions.
Seems like we already do version checks, so we could simply serve a different SVG based on that?

const [major] = window._oc_config?.version.split('.', 2) ?? []

@Antreesy Antreesy force-pushed the backport/7218/stable8 branch from 2c1b1f9 to 1ef9f40 Compare July 30, 2025 08:46
@Antreesy Antreesy requested review from ShGKme and susnux July 30, 2025 08:46
@Antreesy
Copy link
Contributor

Antreesy commented Jul 30, 2025

Added legacy check through loadState (so it works with Talk Desktop)

There are two more components with window._oc_config?.version check, will change them to loadState as well, if we agreed

Antreesy added 2 commits July 30, 2025 11:04
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/7218/stable8 branch from 1ef9f40 to 72f6d94 Compare July 30, 2025 09:05
@susnux susnux merged commit 6e42b94 into stable8 Jul 30, 2025
20 of 25 checks passed
@susnux susnux deleted the backport/7218/stable8 branch July 30, 2025 11:21
@susnux susnux mentioned this pull request Aug 18, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UX, interface and interaction design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants