feat(NcColorPicker): add proper open-state handling #7212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly for more consistent event naming, as the closing is happening after the `shown` state changed. The *closed* state is meaning that all transistions have finished. This is in-line with other events of similar use case. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
There was undocumented usage of the underlying `NcPopover` `shown` prop. Instead this now provides the offical `open` prop for this usage. The name was choosen because `open` is more consistently used in our codebase for this use case instead of `shown`. This also reverts the breaking changes entry for the `update:open` event. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
enhancement
susnux
changed the title
ShGKme
approved these changes
Jul 28, 2025
Antreesy
approved these changes
Jul 28, 2025
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
With #7080 we dropped the
update:openevent, but the usage of the component is different - as you can already see in the docs of it. We in-officially used the attributes passing to the underlyingNcPopoverfor custom open state handling.So instead of this we should revert that change and instead just implement it correctly by providing the 2-way binding for
open(consistent props naming) - then we need to reverse the event removal and removeclose(which is covered byupdate:openand for fully closed (transitions done) the proper (consistent) named eventclosed).I would backport the
featcommits to v8 for forward compatibility.🏁 Checklist
stable8for maintained Vue 2 version or not applicable