Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 16, 2025

☑️ Resolves

Ensure that all browsers show our clear button instead of some non-themed clear button of the browser implementation. This only happened for search boxes.

🖼️ Screenshots

🏚️ Before (firefox) 🏚️ Before (chrome) 🏡 After (all!)
Bildschirmfoto_20250716_160118 Bildschirmfoto_20250716_160124 Bildschirmfoto_20250716_160118

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Ensure that **all** browsers show **our** clear button instead of some
non-themed clear button of the browser implementation.
This only happened for search boxes.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the 9.0.0-rc.5 milestone Jul 16, 2025
@susnux susnux requested review from Antreesy, skjnldsv and szaimen July 16, 2025 14:05
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component design Design, UX, interface and interaction design labels Jul 16, 2025
@susnux
Copy link
Contributor Author

susnux commented Jul 16, 2025

/backport to stable8

@susnux susnux added feature: input-field Covering the InputField, TextField, ... and removed feature: app-navigation Related to the app-navigation component labels Jul 16, 2025
Comment on lines +348 to +354
// prevent Blink and WebKit to add an additional button when type is set to search
// we have our properly styled trailing button anyways.
&::-webkit-search-cancel-button {
// its a weird bug in Blink that this rule must not be grouped with the other selectors below.
// otherwise it is not recognized by Blink
display: none;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Firefox?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not mess with it ;)

@susnux susnux merged commit fe39245 into main Jul 16, 2025
25 checks passed
@susnux susnux deleted the fix/input-field-search branch July 16, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: input-field Covering the InputField, TextField, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NcAppNavigationSearch] Inconsistent clear icons

4 participants