fix(NcListItem): correctly handle unmounting #7151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
bug
ShGKme
approved these changes
Jul 15, 2025
susnux
reviewed
Jul 15, 2025
susnux
approved these changes
Jul 15, 2025
| } | ||
| // do not hide if focus is kept within | ||
| if (this.$refs['list-item'].contains(event.relatedTarget)) { | ||
| // On component unmounting Vue 3 resets the template ref to null, |
Contributor
There was a problem hiding this comment.
is it null? thought undefined
Contributor
Author
There was a problem hiding this comment.
Grigorii showed the place in vue code, but I don't have a link unfortunately, Just remember it is set with = null
Contributor
There was a problem hiding this comment.
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/7077/list-item-ref
branch
from
217e9bd to
0f4341c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
$refs.nameis null and therefore can no longer be used🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable