Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 14, 2025

v8.28.0 (2025-07-14)

📝 Notes

NcPasswordField

The component now has a visible property (with update:visible event) to allow setting the visibility state of the password.
This allows to programmatically make the password visible or obfuscated for the user.
One use case could be to reset the visibility when submitting some form to prevent leaking the password in a loading state of the UI.

NcTextField

The value arrowRight of the property trailingButtonIcon is deprecated and will be removed in a future version.
It is replaced by arrowEnd which reflects that the directions depends on the text directions (LTR vs RTL).

NcColorPicker

The update:open event is deprecated, instead just use the close event which is emitted at the same time.

Event names

Custom events now have a consistent naming without custom scoping of the events.
Thus following events are deprecated in favor of a new consistent event name:

Component Old event New event
NcAppContent resize:list resize-list
NcRichText interact:todo interact-todo

🚀 Enhancements

🐛 Fixed bugs

Other Changes

@susnux susnux added this to the 8.28.0 milestone Jul 14, 2025
@susnux susnux added the 3. to review Waiting for reviews label Jul 14, 2025
@susnux susnux force-pushed the chore/prepare-8-28 branch 2 times, most recently from bddd8ee to 7d14020 Compare July 14, 2025 13:06
@Antreesy
Copy link
Contributor

Comment on lines +11 to +15
#### `NcPasswordField`
The component now has a `visible` property (with `update:visible` event) to allow setting the visibility state of the password.
This allows to programmatically make the password visible or obfuscated for the user.
One use case could be to reset the visibility when submitting some form to prevent leaking the password in a loading state of the UI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is not a breaking change or something developers need to pay attention to.

Seems to be a general new feature for a specific use case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Antreesy asked for it :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should always be descriptive and inform about:

  • breaking changes;
  • deprecated things;
  • new features.

Although a one-liner what it's for would be enough =)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • new features.

They are already listed in the dedicated 🚀 Enhancements section 👀

I think, it makes sense to add a long note about a new feature, if it's something big, that requires additional attention. Such as a new component that should be used instead of existing.

Here, for instance, useFormatRelativeTime partically replacing moment seems much more important than a new prop in the password field.

Although a one-liner what it's for would be enough =)

We have one line description at home in the changelog: allow to set visibility state from the PR title. Seems fine to me.

Can also be more detailed to explicitply mention new prop like:

  • feat(NcPasswordField): add visible model to set password visibility state

@susnux susnux requested a review from Antreesy July 14, 2025 13:47
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/prepare-8-28 branch from 1ede2e3 to 75fff62 Compare July 14, 2025 13:53
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@susnux susnux merged commit dfef9fe into stable8 Jul 14, 2025
24 of 29 checks passed
@susnux susnux deleted the chore/prepare-8-28 branch July 14, 2025 15:01
@ShGKme
Copy link
Contributor

ShGKme commented Jul 14, 2025

All the notes are missing in the release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants