-
Notifications
You must be signed in to change notification settings - Fork 95
chore: prepare v8.28.0 #7149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare v8.28.0 #7149
Conversation
bddd8ee to
7d14020
Compare
|
| #### `NcPasswordField` | ||
| The component now has a `visible` property (with `update:visible` event) to allow setting the visibility state of the password. | ||
| This allows to programmatically make the password visible or obfuscated for the user. | ||
| One use case could be to reset the visibility when submitting some form to prevent leaking the password in a loading state of the UI. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is not a breaking change or something developers need to pay attention to.
Seems to be a general new feature for a specific use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Antreesy asked for it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should always be descriptive and inform about:
- breaking changes;
- deprecated things;
- new features.
Although a one-liner what it's for would be enough =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- new features.
They are already listed in the dedicated 🚀 Enhancements section 👀
I think, it makes sense to add a long note about a new feature, if it's something big, that requires additional attention. Such as a new component that should be used instead of existing.
Here, for instance, useFormatRelativeTime partically replacing moment seems much more important than a new prop in the password field.
Although a one-liner what it's for would be enough =)
We have one line description at home in the changelog: allow to set visibility state from the PR title. Seems fine to me.
Can also be more detailed to explicitply mention new prop like:
- feat(NcPasswordField): add
visiblemodel to set password visibility state
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1ede2e3 to
75fff62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
|
All the notes are missing in the release notes |
v8.28.0 (2025-07-14)
📝 Notes
NcPasswordFieldThe component now has a
visibleproperty (withupdate:visibleevent) to allow setting the visibility state of the password.This allows to programmatically make the password visible or obfuscated for the user.
One use case could be to reset the visibility when submitting some form to prevent leaking the password in a loading state of the UI.
NcTextFieldThe value
arrowRightof the propertytrailingButtonIconis deprecated and will be removed in a future version.It is replaced by
arrowEndwhich reflects that the directions depends on the text directions (LTR vs RTL).NcColorPickerThe
update:openevent is deprecated, instead just use thecloseevent which is emitted at the same time.Event names
Custom events now have a consistent naming without custom scoping of the events.
Thus following events are deprecated in favor of a new consistent event name:
NcAppContentresize:listresize-listNcRichTextinteract:todointeract-todo🚀 Enhancements
useFormatRelativeTimecomposable #7128 (backportbot[bot])🐛 Fixed bugs
activeprop take higher priority #7089 (backportbot[bot])Other Changes
update:openevent #7095 (backportbot[bot])NodeList#7105 (backportbot[bot])