fix(NcNoteCard): too large icon padding #7118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
added
3. to review
Antreesy
approved these changes
Jul 3, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Note: that's to override .icon-vue:
min-width: var(--default-clickable-area);
min-height: var(--default-clickable-area);
Looks fine to me
susnux
reviewed
Jul 3, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
It this really needed? If I am correct all thats needed here (and was forgotten) is to set the inline prop of the NcIconSvgWrapper for the icon.
ShGKme
requested changes
Jul 3, 2025
Contributor
Author
|
Inline prop works. Please set my DCO to pass, I only have my mobile at hand right now. |
ShGKme
force-pushed
the
fix/7117/notecard-icon-size
branch
from
9fcecc6 to
364d82b
Compare
Contributor
|
Squashed into a single commit |
Signed-off-by: Raimund Schlüßler <raimund.schluessler+nextcloud@mailbox.org> Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/7117/notecard-icon-size
branch
from
364d82b to
cb5bb22
Compare
ShGKme
approved these changes
Jul 5, 2025
ShGKme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicable