fix(NcActionText): remove br between action name and action long text #7116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: greta <gretadoci@gmail.com>
Contributor
Author
|
/backport to stable8 |
ChristophWurst
approved these changes
Jul 2, 2025
Contributor
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
That looks a lot better 👏
Antreesy
approved these changes
Jul 2, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
I'll follow-up with 'description' prop PR later, still think it makes sense to have it aligned with other components
Contributor
Author
i can do that as well, if you think we must have it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The
bradds too much space betweenaction-text__nameandaction-text__longtext. Talk app and Mail app use NcActionText and so far we could find only these apps where it breaks.On NcActionButton Maksim solved it by adding a description prop, but in our case the entry is fully informational and standalone(cn).
🖼️ Screenshots
🏚️ Before | 🏡 After
|
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable