Skip to content

fix(useHotKey): try to derive latin keys from key codes of non-latin characters #7110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

fix(useHotKey): try to derive latin keys from key codes of non-latin characters #7110

merged 1 commit into from
Jul 14, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 1, 2025 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

en ru de
image image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added this to the 9.0.0-rc.4 milestone Jul 1, 2025
@Antreesy Antreesy requested review from DorraJaouad, ShGKme and susnux July 1, 2025 13:08
@Antreesy Antreesy self-assigned this Jul 1, 2025
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: functions composables, functions, mixins and other non-components labels Jul 1, 2025
@susnux
Copy link
Contributor

susnux commented Jul 7, 2025

/backport to stable8

ShGKme
ShGKme reviewed Jul 7, 2025
View reviewed changes
@Antreesy Antreesy requested a review from ShGKme July 8, 2025 08:31
@Antreesy Antreesy force-pushed the fix/noid/use-hotkey-codes branch from a6cc10e to 6421a7a Compare July 10, 2025 11:12
susnux
susnux reviewed Jul 11, 2025
View reviewed changes
susnux
susnux reviewed Jul 11, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/noid/use-hotkey-codes branch from 6421a7a to b2ff9d0 Compare July 11, 2025 17:11
@Antreesy Antreesy changed the title fix(useHotKey): allow to pass key codes ('a' as 'KeyA') fix(useHotKey): try to derive latin keys from key codes of non-latin characters Jul 11, 2025
@Antreesy Antreesy requested a review from susnux July 11, 2025 17:11
susnux
susnux reviewed Jul 11, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/noid/use-hotkey-codes branch from b2ff9d0 to 0c4d055 Compare July 11, 2025 18:43
susnux
susnux reviewed Jul 11, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/noid/use-hotkey-codes branch from 0c4d055 to a1b94f1 Compare July 12, 2025 09:37
susnux
susnux approved these changes Jul 12, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/noid/use-hotkey-codes branch 2 times, most recently from f2794f8 to b58fa1a Compare July 12, 2025 17:01
ShGKme
ShGKme approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@Antreesy
fix(useHotKey): try to derive latin keys from key codes of non-latin …
fd97eb2 
…characters

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/use-hotkey-codes branch from b58fa1a to fd97eb2 Compare July 14, 2025 09:08
@Antreesy Antreesy enabled auto-merge July 14, 2025 09:09
@Antreesy Antreesy merged commit 33ffb8d into main Jul 14, 2025
25 checks passed
@Antreesy Antreesy deleted the fix/noid/use-hotkey-codes branch July 14, 2025 09:13
@backportbot backportbot bot mentioned this pull request Jul 14, 2025
Merged
@susnux susnux mentioned this pull request Jul 15, 2025
Merged
@Antreesy Antreesy mentioned this pull request Jul 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews bug Something isn't working feature: functions composables, functions, mixins and other non-components

Projects

None yet

Milestone

9.0.0-rc.4

Development

Successfully merging this pull request may close these issues.

Hotkeys do not work on non-latin keyboard layouts (e.g., Cyrillic)

4 participants

@Antreesy @susnux @ShGKme