Skip to content

Conversation

@DorraJaouad
Copy link
Contributor

☑️ Resolves

  • If we pass :active="false and current item has an active path, it will bypass the explicit prop. This is also needed as vue-router 4 active changing behavior where there is a wider range of paths considered active -> we rely more on prop to better maintain the previous behavior.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 9.0.0-rc.3 milestone Jun 24, 2025
@DorraJaouad DorraJaouad requested review from Antreesy and susnux June 24, 2025 14:58
@DorraJaouad DorraJaouad self-assigned this Jun 24, 2025
@DorraJaouad DorraJaouad added bug Something isn't working 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Jun 24, 2025
@Antreesy Antreesy requested a review from ShGKme June 24, 2025 15:10
@DorraJaouad DorraJaouad merged commit 1926b04 into main Jun 24, 2025
25 checks passed
@DorraJaouad DorraJaouad deleted the fix/nc-list-item-active branch June 24, 2025 16:56
@DorraJaouad
Copy link
Contributor Author

/backport to stable8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: list-item Related to the list-item component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants