Skip to content

fix(NcModal): correctly handle when trying to activate non-existing focus-trap #7084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

fix(NcModal): correctly handle when trying to activate non-existing focus-trap #7084

merged 1 commit into from
Jun 24, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 24, 2025 •
edited
Loading

☑️ Resolves

  • Fix handling of focus trap stack, if there are several
  • Fix issue when trying to activate non-existing focus-trap
  • Copied form NcEmojiPicker
  • Tested in Talk

🖼️ Screenshots

Before

image

After

2025-06-24_12h47_47.mp4

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy
fix(NcModal): use useTrapStackControl for pausing other focus traps
f07e66b 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 9.0.0-rc.3 milestone Jun 24, 2025
@Antreesy Antreesy self-assigned this Jun 24, 2025
@Antreesy Antreesy added 3. to review Waiting for reviews feature: modal Related to the modal component labels Jun 24, 2025
@Antreesy
Copy link
Contributor Author

/backport to stable8

@Antreesy Antreesy merged commit 0979f29 into main Jun 24, 2025
25 checks passed
@Antreesy Antreesy deleted the fix/noid/focus-trap-handling branch June 24, 2025 11:47
@backportbot backportbot bot mentioned this pull request Jun 24, 2025
Closed
2 tasks
@ShGKme
Copy link
Contributor

ShGKme commented Jun 24, 2025

Please adjust the title to explain what bug was fixed (for the changelog)

@Antreesy Antreesy changed the title fix(NcModal): use useTrapStackControl for pausing other focus traps fix(NcModal): corectly handle when trying to activate non-existing focus-trap Jun 24, 2025
@DorraJaouad DorraJaouad changed the title fix(NcModal): corectly handle when trying to activate non-existing focus-trap fix(NcModal): correctly handle when trying to activate non-existing focus-trap Jun 24, 2025
@Antreesy Antreesy mentioned this pull request Jun 25, 2025
Merged
This was referenced Aug 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews feature: modal Related to the modal component

Projects

None yet

Milestone

9.0.0-rc.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @ShGKme @DorraJaouad