Skip to content

fix(NcButton): correctly apply reverse padding #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

fix(NcButton): correctly apply reverse padding #7029

merged 1 commit into from
Jun 10, 2025

Conversation

@raimund-schluessler
Copy link
Contributor

☑️ Resolves

This correctly applies the padding for reverse buttons.

Regression from #6033.

🖼️ Screenshots

🏚️ Before 🏡 After
grafik grafik

Comparison to stable8:
grafik

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@raimund-schluessler
fix(NcButton): correctly apply reverse padding
5f5c609 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added this to the 9.0.0-rc.3 milestone Jun 10, 2025
@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature design Design, UX, interface and interaction design feature: button labels Jun 10, 2025
@raimund-schluessler raimund-schluessler marked this pull request as ready for review June 10, 2025 07:35
susnux
susnux approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work

@susnux susnux merged commit db39fe3 into main Jun 10, 2025
27 checks passed
@susnux susnux deleted the fix/7005/button-reverse-padding-2 branch June 10, 2025 12:41
@Antreesy Antreesy mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: button regression Regression of a previous working feature

Projects

None yet

Milestone

9.0.0-rc.3

Development

Successfully merging this pull request may close these issues.

[NcButton]: *-reverse variants have wrong padding

4 participants

@raimund-schluessler @susnux @Antreesy