refactor: migrate reference widget related function to Typescript #6969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
julien-nc,
juliusknorr,
max-nextcloud and
raimund-schluessler
max-nextcloud
approved these changes
Jun 30, 2025
Contributor
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Only did a short code review. It's somewhat difficult to review the changes given the files have been renamed and the entire files are shown as added or removed.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/functions-reference-ts
branch
from
015bf26 to
4be07ed
Compare
Contributor
Author
|
For better review I split the commits, the first only renames the files. |
julien-nc
approved these changes
Jun 30, 2025
Contributor
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Code looks good. I didn't link it and try it though.
Contributor
|
/backport to stable8 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Migrated code to Typescript, also added some docs where I knew what it is about ;)
🏁 Checklist
stable8for maintained Vue 2 version or not applicable