chore(NcRichContenteditable)!: remove title prop in favor of label
#6962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was deprecated in v8 and need to be removed in v9. Affects: - `NcAutoCompleteResult` - `NcMentionBubble` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
3. to review
Antreesy
approved these changes
May 26, 2025
| - The `isFullscreen`, and `isMobile` mixins were removed. Use the according composables instead. | ||
| - The `clickOutsideOptions` mixin is removed | ||
| - The `box-sizing: border-box` is now default for following components and its content. This is done to match behaviour of `NcContent` (as they can be mounted directly to `body`): | ||
| - The `box-sizing: border-box` is now default for following components and its content. This is done to match behavior of `NcContent` (as they can be mounted directly to `body`): |
Contributor
There was a problem hiding this comment.
Isn't it American English? 👀
Contributor
Author
There was a problem hiding this comment.
Ou is British, like colour vs color.
max-nextcloud
approved these changes
May 27, 2025
ShGKme
changed the title
title prop in favor of labeltitle prop in favor of label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Was deprecated in v8 and need to be removed in v9. Affects:
NcAutoCompleteResultNcMentionBubbletitle only was added by accident, the backend provides
labelso only semantically breaking, but should not affect users.🏁 Checklist
stable8for maintained Vue 2 version or not applicable