Skip to content

fix(NcChip): do not rerender slots to check if they are available #6903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

fix(NcChip): do not rerender slots to check if they are available #6903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/NcChip/NcChip.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,24 +171,24 @@ const slots = defineSlots<{
/**
* The actions slot can be used to add custom actions (`NcAction*`) to the chips actions.
*/
actions: Slot
actions?: Slot

/**
* The default slot can be used to set the text that is shown.
*/
default: Slot
default?: Slot

/**
* The icon slot can be used to set the chip icon.
* Make sure that the icon is not exceeding a height of `--chip-size`.
* For round icons a exact size of `var(--chip-size)` is recommended.
*/
icon: Slot
icon?: Slot
}>()

const canClose = computed(() => !props.noClose)
const hasActions = () => Boolean(slots.actions?.())
const hasIcon = () => Boolean(props.iconPath || props.iconSvg || !!slots.icon?.())
const hasActions = () => !!slots.actions
const hasIcon = () => Boolean(props.iconPath || props.iconSvg || !!slots.icon)
</script>

<style scoped lang="scss">
Expand Down
Loading