refactor(NcUserStatusIcon): migrate component to Typescript #6820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
force-pushed
the
refactor/nc-user-status-icon-ts
branch
from
4f29f49 to
441e8e7
Compare
Antreesy
approved these changes
May 13, 2025
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Looks fine, but didn't test it.
Not sure if some convertations from null to undefined would work correctly (e.g. ariaLabel as undefined should be OK, but v-html directive? status model being null/undefined?
ShGKme
reviewed
May 13, 2025
susnux
force-pushed
the
refactor/nc-user-status-icon-ts
branch
2 times, most recently
from
d76b33b to
f90cf02
Compare
ShGKme
approved these changes
May 13, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/nc-user-status-icon-ts
branch
from
f90cf02 to
b269847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Migrate the component to Typescript + script setup.
Also added tests to prevent regressions.
🏁 Checklist
stable8for maintained Vue 2 version or not applicable