Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Apr 18, 2025

Backport of #6807

Warning, This backport had conflicts that were resolved with the ours merge strategy and is likely incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Antreesy, ShGKme and susnux April 18, 2025 23:40
@backportbot backportbot bot added 3. to review Waiting for reviews feature: popover Related to the popovermenu component 💥 breaking PR that requires a new major version labels Apr 18, 2025
@backportbot backportbot bot added this to the 8.26.0 milestone Apr 18, 2025
Replacing the `focusTrap` prop to have prop with default of `false`
allowing to use HTML short cut attributes `<NcPopover no-focus-trap />`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/6807/stable8 branch from a436dd2 to 603590d Compare April 20, 2025 10:20
@susnux susnux marked this pull request as ready for review April 20, 2025 10:21
@susnux susnux added enhancement New feature or request and removed 💥 breaking PR that requires a new major version labels Apr 20, 2025
@susnux susnux merged commit 3997ee5 into stable8 Apr 22, 2025
24 of 25 checks passed
@susnux susnux deleted the backport/6807/stable8 branch April 22, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: popover Related to the popovermenu component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants