Skip to content

fix(NcActions): trigger forgotten closed event and correctly handle open #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix(NcActions): trigger forgotten closed event and correctly handle open #6706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/components/NcActions/NcActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1369,6 +1369,15 @@
})
},

onClosed() {
/**
* Event emitted when the popover menu is closed.
*
* This event is emitted after `update:open` was emitted and the closing transition finished.
*/
this.$emit('closed')
},

/**
* Handle resizing the popover to make sure users can discover there is more to scroll
*/
Expand Down Expand Up @@ -1408,7 +1417,7 @@
},

/**
* @return {NodeListOf<HTMLElement>}

Check warning on line 1420 in src/components/NcActions/NcActions.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

The type 'NodeListOf' is undefined
*/
getFocusableMenuItemElements() {
return this.$refs.menu.querySelectorAll(focusableSelector)
Expand Down Expand Up @@ -1760,7 +1769,8 @@
setReturnFocus: this.config.withFocusTrap ? this.$refs.triggerButton?.$el : null,
focusTrap: this.config.withFocusTrap,
onShow: this.openMenu,
onApplyShow: this.onOpen,
onAfterShow: this.onOpened,
onAfterClose: this.onClosed,
onHide: this.closeMenu,
},
{
Expand Down
Loading