Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 21, 2025

Backport of #6636

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

@backportbot backportbot bot requested review from Antreesy, ShGKme and susnux March 21, 2025 17:06
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: header-menu labels Mar 21, 2025
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/6636/next branch from 3d34d9a to 2e761b3 Compare March 21, 2025 17:27
@Antreesy
Copy link
Contributor

NcHeaderMenu was already refactored to include $el

@Antreesy Antreesy marked this pull request as ready for review March 21, 2025 17:28
@ShGKme ShGKme merged commit 40de0a7 into next Mar 22, 2025
26 checks passed
@ShGKme ShGKme deleted the backport/6636/next branch March 22, 2025 16:14
@ShGKme ShGKme changed the title [next] fix(focus-trap): provide HTMLElement as fallbackFocus [next] fix(NcAppSidebar, NcHeaderMenu): correctly focus trigger/close buggon when no focusable elements inside Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: header-menu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants