Skip to content

docs: adjust version number for variant props #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

docs: adjust version number for variant props #6623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/NcActions/NcActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@
* Accepted values: primary, secondary, tertiary, tertiary-no-background, tertiary-on-primary, error, warning, success.
* If left empty, the default button style will be applied.
*
* @since 8.23.0
* @since 8.24.0
*/
variant: {
type: String,
Expand Down Expand Up @@ -1516,7 +1516,7 @@
return this.$refs.menu.querySelector('li.active')
},
/**
* @return {NodeListOf<HTMLElement>}

Check warning on line 1519 in src/components/NcActions/NcActions.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

The type 'NodeListOf' is undefined
*/
getFocusableMenuItemElements() {
return this.$refs.menu.querySelectorAll(focusableSelector)
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcButton/NcButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ export default {
* Accepted values: primary, secondary, tertiary, tertiary-no-background, tertiary-on-primary, error, warning, success.
*
* @default 'secondary'
* @since 8.23.0
* @since 8.24.0
*/
variant: {
type: String,
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcChip/NcChip.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ const props = defineProps({
* Set the chips design variant-
*
* This sets the background style of the chip, similar to NcButton's `variant`.
* @since 8.23.0
* @since 8.24.0
*/
variant: {
type: String,
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcDialogButton/NcDialogButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const props = defineProps({
* The button variant, see NcButton.
*
* @type {'primary'|'secondary'|'tertiary'|'error'|'warning'|'success'}
* @since 8.23.0
* @since 8.24.0
*/
variant: {
type: String,
Expand Down
Loading