Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDateTimePickerNative): do not set invalid value #6387

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix(NcDateTimePickerNative): do not set invalid value #6387

merged 1 commit into from
Jan 21, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 15, 2025 •
edited
Loading

☑️ Resolves

  • Fix setting this.model twice from @input events (invalid, 'month')

🖼️ Screenshots

🏚️ Before 🏡 After
image image

Docs:
image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component labels Jan 15, 2025
@Antreesy Antreesy added this to the 8.21.1 milestone Jan 15, 2025
@Antreesy Antreesy self-assigned this Jan 15, 2025
@Antreesy Antreesy marked this pull request as draft January 15, 2025 13:29
@Antreesy Antreesy force-pushed the fix/noid/date-picker-invalid branch 2 times, most recently from 088b166 to 6c097e0 Compare January 15, 2025 13:59
@Antreesy Antreesy marked this pull request as ready for review January 15, 2025 13:59
@Antreesy Antreesy requested a review from susnux January 15, 2025 15:10
@Antreesy Antreesy force-pushed the fix/noid/date-picker-invalid branch from 6c097e0 to a935181 Compare January 15, 2025 15:43
@susnux susnux modified the milestones: 8.21.1, 8.23.0 Jan 15, 2025
@Antreesy
fix(NcDateTimePickerNative): do not set invalid values
e758db5 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/date-picker-invalid branch from a935181 to e758db5 Compare January 21, 2025 17:37
@Antreesy
Copy link
Contributor Author

/backport to next

@Antreesy Antreesy merged commit 44cc2fd into master Jan 21, 2025
19 checks passed
@Antreesy Antreesy deleted the fix/noid/date-picker-invalid branch January 21, 2025 17:39
@backportbot backportbot bot mentioned this pull request Jan 21, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: datepicker Related to the date/time picker component
Projects
None yet
Milestone
8.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @ShGKme