Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): open _blank link by Enter and allow prevent #5342

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix(NcListItem): open _blank link by Enter and allow prevent #5342

merged 1 commit into from
Mar 8, 2024

Conversation

pulsejet
Copy link
Contributor

@pulsejet pulsejet commented Mar 4, 2024 •
edited
Loading

I don't understand what that line is intended to do.

  1. It prevents target=_blank above from working at all
  2. You can't call preventDefault on the event anymore

This just makes zero sense to me.

My guess is, this is for the keyboard event? (even then, enter always triggers click if href is present, which should always be)

Regardless, switched that to a explicit trigger.

@pulsejet pulsejet force-pushed the varun/listitem branch 2 times, most recently from 3e9de23 to 3a6e079 Compare March 4, 2024 23:28
@pulsejet pulsejet mentioned this pull request Mar 4, 2024
Closed
4 tasks
@pulsejet pulsejet requested review from susnux and ShGKme March 4, 2024 23:52
@pulsejet
Copy link
Contributor Author

pulsejet commented Mar 7, 2024

Hello?

@susnux susnux requested review from skjnldsv and Pytal March 7, 2024 16:42
@pulsejet
NcListItem: don't explicitly set location
5c4bb63 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@pulsejet pulsejet requested a review from ShGKme March 7, 2024 21:41
@skjnldsv
Copy link
Contributor

skjnldsv commented Mar 7, 2024

Hello?

We're in the rush of the 29 release. Things are a bit busy at the moment, sorry 😔

ShGKme
ShGKme approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Works fine with a router link and a native link, with _blank and _self, by click and by enter/space, preventable with preventDefault().

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Mar 8, 2024
@ShGKme ShGKme added this to the 8.10.0 milestone Mar 8, 2024
@ShGKme ShGKme changed the title NcListItem: don't explicitly set location fix(NcListItem): open _blank link by Enter and allow prevent Mar 8, 2024
@ShGKme ShGKme merged commit 4bb2677 into master Mar 8, 2024
18 checks passed
@ShGKme ShGKme deleted the varun/listitem branch March 8, 2024 10:03
@ShGKme
Copy link
Contributor

ShGKme commented Mar 8, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 8, 2024
Merged
@ShGKme ShGKme mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: list-item Related to the list-item component
Projects
None yet
Milestone
8.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pulsejet @skjnldsv @ShGKme @susnux