Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix(NcPopover): add aria-modal to some popover-based dialog components #5327

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[next] fix(NcPopover): add aria-modal to some popover-based dialog components #5327

merged 1 commit into from
Feb 29, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 29, 2024 •
edited by ShGKme
Loading

Backport of #5309

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: popover Related to the popovermenu component feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: colorpicker Related to the colorpicker component feature: emoji picker Related to the emoji picker component labels Feb 29, 2024
Antreesy
Antreesy approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@ShGKme
Copy link
Contributor

ShGKme commented Feb 29, 2024

The backport is not complete, waiting for #5329

@ShGKme ShGKme force-pushed the backport/5309/next branch from 7df455d to 90aeddb Compare February 29, 2024 13:30
@ShGKme
fix(NcPopover): add aria-modal to some popover-based dialog components
388098f 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the backport/5309/next branch from 90aeddb to 388098f Compare February 29, 2024 13:32
@ShGKme ShGKme marked this pull request as ready for review February 29, 2024 13:32
@ShGKme ShGKme enabled auto-merge February 29, 2024 13:32
@ShGKme ShGKme merged commit a6a9077 into next Feb 29, 2024
18 checks passed
@ShGKme ShGKme deleted the backport/5309/next branch February 29, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components feature: colorpicker Related to the colorpicker component feature: emoji picker Related to the emoji picker component feature: popover Related to the popovermenu component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @JuliaKirschenheuter @Antreesy