Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Currently the menu in
NcActions
has the following structure:POPUP_ROLE
can be -menu | dialog | tooltip
or nothing (=list
) in navigation:menu
,<li>
has rolepresentation
, because there aremenuitem
-s inside.dialog
ortooltip
,<li>
had nativelistitem
role because there is a list in the popup.The problem is that in the last case
<UL>
is at the same time:list
roledialog
ortooltip
role.But it is not possible to have 2 roles. So, when it is a
dialog
ortooltip
, list items are not in a list.A proper solution should have been to wrap
UL
into another element.However, we decided that this is too risky change of the structure for apps and testing.
Temporal solution - remove
listitem
role indialogs
andtooltips
.🖼️ Screenshots
🚧 Tasks
NcActions
context with as menu type and LI roleisSemanticMenu
to provide more important datainject
NcActionSeparator
(it is alwaysseparator
)P.S.
I haven't used existing mixins (
actionText
,actionGlobal
) because they are not used on all the action items.I haven't created a new mixin, because I decided, that we should move to composables.
🏁 Checklist