enh(NcAppNavigationItem): Allow to pass SVG or path as icon property #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
enh/allow-svg-and-path-icon-app-navigation
branch
from
2b1956e to
ff4cc48
Compare
|
Is it required for a specific place? Why not use the icon slot? |
I can do so. Whats then the plan with the icon props? Should we deprecate them as icon classes are deprecated and just recommend using icon slots with svg wrapper. Or should be move them to SVG support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Not only allow icon classes (somewhat deprecated) but also SVG or SVG paths as icon property.
🖼️ Screenshots
🏁 Checklist