Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename title props and slots to name #4106

Merged
merged 1 commit into from
May 16, 2023
Merged

Rename title props and slots to name #4106

merged 1 commit into from
May 16, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented May 12, 2023 •
edited
Loading

This PR renames every occurrence of title to name if it does not relate to the native HTML title attribute.

Closes #4053.

Migration guide:

  • Rename title prop to name for the following components:
    • NcActionButtonGroup
    • NcActionCaption
    • NcAppNavigationCaption
    • NcAppNavigationNewItem
    • NcAppNavigationSettings
    • NcAppSettingsDialog
    • NcAppSettingsSection
    • NcAppSidebar
    • NcEmptyContent
    • NcIconSvgWrapper
    • NcListItem
    • NcListItemIcon
    • NcLoadingIcon
    • NcModal
    • NcResource
    • NcSavingIndicatorIcon
    • NcSettingsSection
  • NcActions:
    • Rename force-title prop to force-name
    • Rename menu-title prop to menu-name
  • NcAppSidebar:
    • Rename titleEditable prop to nameEditable
    • Rename titlePlaceholder prop to namePlaceholder
    • Rename subtitle prop to subname
    • Rename subtitleTooltip prop to subtitle
    • Rename linkifyTitle prop to linkifyName
    • Rename titleTooltip prop to title
    • Rename update:titleEditable event to update:nameEditable
    • Rename update:title event to update:name
    • Rename submit-title event to submit-name
  • NcEmojiPicker:
    • Rename previewFallbackTitle prop to previewFallbackName
  • NcEmptyContent:
    • Rename title slot to name
  • NcListItem:
    • Rename subtitle slot to subname
  • NcListItemIcon:
    • Rename subtitle prop to subname
    • Rename iconTitle prop to iconName
  • NcModal:
    • Rename playPauseTitle to playPauseName
  • NcMentionBubble:
    • Rename label prop to title
  • NcUserBubble:
    • Rename title slot to name

@raimund-schluessler raimund-schluessler linked an issue May 12, 2023 that may be closed by this pull request
Rename title props to name #4053
Closed
@raimund-schluessler raimund-schluessler added 2. developing Work in progress component Component discussion and/or suggestion technical debt breaking PR that requires a new major version labels May 12, 2023
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone May 12, 2023
@raimund-schluessler raimund-schluessler changed the title WIP: Rename title props and slots to name WIP: Rename title props and slots to name May 12, 2023
@raimund-schluessler raimund-schluessler force-pushed the fix/4053/title-to-name branch 6 times, most recently from ea4a21b to 253fd69 Compare May 14, 2023 18:52
@raimund-schluessler raimund-schluessler changed the title WIP: Rename title props and slots to name Rename title props and slots to name May 14, 2023
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 14, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review May 14, 2023 18:55
@raimund-schluessler
Rename title props and slots to name
bb2cf54 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler merged commit 9c63560 into master May 16, 2023
@raimund-schluessler raimund-schluessler deleted the fix/4053/title-to-name branch May 16, 2023 19:21
@raimund-schluessler raimund-schluessler mentioned this pull request May 25, 2023
Closed
3 tasks
@juliusknorr juliusknorr mentioned this pull request May 30, 2023
Merged
3 tasks
@Pytal Pytal mentioned this pull request Jun 13, 2023
Merged
2 tasks
@susnux susnux mentioned this pull request Jun 15, 2023
Merged
2 tasks
@juliusknorr juliusknorr mentioned this pull request Jun 29, 2023
Merged
1 task
@Antreesy Antreesy mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@ShGKme ShGKme Awaiting requested review from ShGKme

@susnux susnux Awaiting requested review from susnux

Assignees
No one assigned
Labels
3. to review Waiting for reviews breaking PR that requires a new major version component Component discussion and/or suggestion technical debt
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Rename title props to name
4 participants
@raimund-schluessler @nickvergessen @skjnldsv @marcoambrosini