Skip to content

Conversation

@Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 4, 2022

Add minlength and maxlength to be forwarded to the input by v-bind="$props"

The part which adds the autofocus prop definition is an addendum to #3245

Before this change autofocus wasn't contained in $props so it wasn't automatically forwarded by v-bind="$props", adding the explicit definition now makes it get forwarded by the v-bind and also makes the prop show up in the docs

@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Oct 4, 2022
@Pytal Pytal added this to the 7.0.0 milestone Oct 4, 2022
@Pytal Pytal self-assigned this Oct 4, 2022
@Pytal Pytal changed the title Add minlength and maxength to text field Add minlength and maxlength to text field Oct 4, 2022
@kesselb
Copy link
Contributor

kesselb commented Oct 10, 2022

Before this change autofocus wasn't contained in $props so it wasn't automatically forwarded by v-bind="$props", adding the explicit definition now makes it get forwarded by the v-bind and also makes the prop show up in the docs

Thank you! Looks much cleaner now 🧹

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jotoeri jotoeri modified the milestones: 7.0.0, 7.0.1 Oct 12, 2022
@Pytal
Copy link
Contributor Author

Pytal commented Oct 18, 2022

/rebase

Pytal added 2 commits October 18, 2022 01:33
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@nextcloud-command nextcloud-command force-pushed the enh/text-field-max-min-length branch from a607b2a to 0cb466f Compare October 18, 2022 01:33
Copy link

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 20, 2022
@Pytal Pytal merged commit e2fad18 into master Oct 20, 2022
@Pytal Pytal deleted the enh/text-field-max-min-length branch October 20, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: input-field Covering the InputField, TextField, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants