Add jquery as depenendency for tributejs

[juliushaertl]

Adds jquery to the vue library as a dependency, to avoid issues during npm link with other repos, which shouldn't matter in terms of building as those are marked as external anyways.

Required for nextcloud/server#33517

[PVince81]

👍

[raimund-schluessler]

@juliushaertl could you please elaborate why this is necessary / helps? Tributejs has literally no dependencies.

[juliushaertl]

@raimund-schluessler You're right, actually the issue is not triggered by tribute.js or nextcloud-vue but the web pack provide plugin that the server uses.

https://github.com/nextcloud/server/blob/master/webpack.common.js#L144

This causes the following tribute.js code to fail then as it tires to resolve it from the linked path:

~/repos/nextcloud/@nextcloud/nextcloud-vue bugfix/noid/popover-focus-trap✦ ➜ rg jQuery node_modules/tributejs/dist/tribute.esm.js
1497:    // Check if it is a jQuery collection
1498:    if (typeof jQuery !== "undefined" && el instanceof jQuery) {
1788:    // Check if it is a jQuery collection
1789:    if (typeof jQuery !== "undefined" && el instanceof jQuery) {

I'll see if there is a way to fix this in the server webpack config.

[juliushaertl]

Found a way nextcloud/server@d78b82b