`AppNavigationItem` actions should be visible on active

[raimund-schluessler]

The counter slot in the AppNavigationItem component is now hidden (or replaced with the Actions menu) when the AppNavigationItem is hovered or active.

While hiding it on hover might be ok (but debatable), I think it is not correct to hide the counter when the item is active. For the Tasks app this would mean that the counter is not visible for the task list currently viewed. This is not intuitive and should be changed, I think.

This will also break the usage in the Calendar and Mail app.

This is a regression due to #3061.

See here:

@marcoambrosini @jancborchardt @nimishavijay for decision

[marcoambrosini]

It should indeed be visible when the element is active @raimund-schluessler, and that should be the case actually. Is it behaving differently? What you're showing in the clip is not the active state

[raimund-schluessler]

Hm, indeed. Let me double check with an actual app (I just looked at it yesterday evening and it behaved weirdly, maybe I mixed something up).

[raimund-schluessler]

@marcoambrosini So I checked with the Tasks app again and there are multiple problems, sadly. The actions are not shown when the entry is active, see here:
Edit: I realized, this is by design, they are only shown on hover and focus, but not if the item is active.

I don't understand why yet, to be honest. I have disabled all custom adjustments, but it still happens.

Furthermore, the app-navigation-entry__utils fixed width of 44px breaks a use case of the Tasks and Calendar app. We also use the counter slot to show the sharing icon and the avatar, which are to be shown permanently. With a fixed width of 44px the sharing icon pushes the counter of the item.

[raimund-schluessler]

So this width:
https://github.com/nextcloud/nextcloud-vue/blob/e28a7178ca938e7175c1c78ee29055f59cdffaef/src/components/NcAppNavigationItem/NcAppNavigationItem.vue#L781
creates issues. It prevents showing Actions and Counter at the same time.

[raimund-schluessler]

And hiding the counter slot content on hover creates the issue that whatever you put into this slot cannot be interactive, since it's hidden when you try to click it. This also breaks the use case of the Calendar and Tasks of putting the sharing and avatar items into the counter slot.

I would like to hear what @ChristophWurst and @skjnldsv think about this. Although the counter slot is by name not meant to contain anything else than a counter, it worked quite well for both apps. So it the counter is to be hidden, we need a new slot for these elements.

[ChristophWurst]

Yes, this is also problematic in Mail where we conditionally show a longer text for the counter: nextcloud/mail#7071 (comment). And this info should show also for active elements.