Icons by default have less-than-useful aria-label/title

[jancborchardt]

For example, the search in the top right was read by screenreaders as "Magnify icon" because that’s the aria-label and title of the icon:

(Fixed via nextcloud/server@83eb806 )

Since even we are doing this mistake, it is very possible that this issue will come up more and more in other apps as well, which would not be good.

Maybe a good solution would be to make the "title" attribute mandatory for icons at least when they are used as icons only? E.g. in the button component where there are icon-only buttons, or in the ActionMenu toggle, or the AppNavigationToggle. @skjnldsv @ma12-co

Edit: Also, the "title" should then be empty if the icon is used decoratively, like in a button component when text is next to it.

[marcoambrosini]

Shouldn't we always use icons decoratively and give the aria-label to their wrappers? That's at least what we're trying to do in talk now

[skjnldsv]

For example, the search in the top right was read by screenreaders as "Magnify icon"

Is it bad?
I mean that seems like a good reading to have when describing a button?