Skip to content

Commit

Permalink
fix(NcActions): move dialog a11y attrs from UL to container
Browse files Browse the repository at this point in the history
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
  • Loading branch information
ShGKme committed Mar 8, 2024
1 parent eb173f2 commit 5b35b7e
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/components/NcActions/NcActions.vue
Original file line number Diff line number Diff line change
Expand Up @@ -1192,6 +1192,7 @@ export default {
},
popoverContainerA11yAttrs: {},
popoverUlA11yAttrs: {
id: this.randomId,
role: 'menu',
},
},
Expand All @@ -1212,13 +1213,14 @@ export default {
triggerA11yAttr: {
'aria-controls': this.opened ? this.randomId : null,
},
popoverContainerA11yAttrs: {},
popoverUlA11yAttrs: {
popoverContainerA11yAttrs: {
id: this.randomId,
role: 'dialog',
// Dialog must have a label
'aria-labelledby': this.triggerRandomId,
'aria-modal': 'true',
},
popoverUlA11yAttrs: {},
},
tooltip: {
popupRole: undefined,
Expand Down Expand Up @@ -1836,7 +1838,6 @@ export default {
}, [
h('ul', {
attrs: {
id: this.randomId,
tabindex: '-1',
...this.config.popoverUlA11yAttrs,
},
Expand Down

0 comments on commit 5b35b7e

Please sign in to comment.