Support vite 5

[susnux]

• Closes chore: Bundle the package using vite + our config #1
• Supersedes chore(deps-dev): Bump vite from 4.5.1 to 5.0.10 #82

This is a bit more complex, the obvious changes:

• Support vite 4.x and 5.x
• Update some dependencies for supporting rollup 4 + vite 5

But there are some other changes required to do so:
Needed to bundle the package as tsc will fail because vite 5 now uses some dependencies that use Node16 module resolution. Therefor we need moduleResolution node16 but this will fail due to a lot of dependency issues.
So the only solution that worked for me was using moduleResolution: Bundler and using vite for bundling the package.
This causes some test issues because now the local vite config would be used for testing, so I needed to adjust the tests a bit.

[codecov]

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (026b470) 81.69% compared to head (c520659) 81.13%.

Files	Patch %	Lines
lib/index.ts	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   81.69%   81.13%   -0.57%     
==========================================
  Files           8        8              
  Lines         579      583       +4     
  Branches       48       48              
==========================================
  Hits          473      473              
- Misses         58       62       +4     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ShGKme]

Did I understand correctly that adding bundling with Vite here is needed, because this import

import type { PluginConfiguration as VitePluginInjectCSSOptions } from 'vite-plugin-css-injected-by-js/dist/esm/declarations/interface.d.ts'

is not allowed because it is not exported by package.json?

We can grab this type as

type VitePluginInjectCSSOptions = Parameters<typeof injectCSSPlugin>[0]

(Or propose the lib author to export all the types)

[susnux]

Did I understand correctly that adding bundling with Vite here is needed, because this import ...

No not only, the main problem is vite 5 importing rollup/parseAst from rollup 4. This is a Node16 import and thus failed for Typescript when set to moduleResolution: node.
But moduleResolution: node16 also fails because that requires extensions in relative imports which failes for some dependencies...

[susnux]

But I would really appreciate any solution :)

[ShGKme]

Did I understand correctly that adding bundling with Vite here is needed, because this import ...

No not only, the main problem is vite 5 importing rollup/parseAst from rollup 4. This is a Node16 import and thus failed for Typescript when set to moduleResolution: node. But moduleResolution: node16 also fails because that requires extensions in relative imports which failes for some dependencies...

Why not moduleResolution: Bundler? It should work as node16 but allows missing extensions

[ShGKme]

But I would really appreciate any solution :)

I've just tried this type instead of import and build via TSC seems to work fine on top of this PR, and all tests have passed.

type VitePluginInjectCSSOptions = Parameters<typeof injectCSSPlugin>[0]

[susnux]

Why not moduleResolution: Bundler? It should work as node16 but allows missing extensions

Because that does not work with Typescript (tsc) 😢

[ShGKme]

Why not moduleResolution: Bundler? It should work as node16 but allows missing extensions

Because that does not work with Typescript (tsc) 😢

Could you add more details on what doesn't work?

It works for me, tested on building @nextcloud/vue + server on top.

(After replacing invalid import)