-
Notifications
You must be signed in to change notification settings - Fork 4
feat: cheap Vue 3 support via separating core login and ui by package exports #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ab24d1a to
e3135f1
Compare
Antreesy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against Talk / Vue 3
|
As this is a breaking change, its still the question if we want to keep this package to depend on vue in general. I would prefer that, but this is also a nice solution :) |
There are no breaking changes. There is still the root export with everything. |
|
This PR is It adds 2 new exports:
The existing |
This comment was marked as outdated.
This comment was marked as outdated.
|
@susnux Please, have a look at the last image in the PR : ) |
This comment was marked as outdated.
This comment was marked as outdated.
But then I still do not see how this solves the problem aslong as this exports a vue component its not universal. Then we also could just migrate the library as is? |
If time allows, that would be nice. |
This library has Vue component This But when everything is exported together from a single This changes separates these parts. It allows importing If we continue as shown on the new image, then all the other functions can also be used with shipped Vue. |
Only for a one thing - |
Yes, but it is independent. And you still need to use library in Vue 2 apps. |
Unlike UI functions that uses Vue internaly, this component is exported as a Vue component and must be used in a specific Vue version. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
This allows installing package in Vue 3 environment. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
e3135f1 to
7a366ef
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Resolves
@nextcloud/uploadshas uploading logic and ui mixedcore- pure uploading logicui- UI related functions (dialogs) that use Vue only internallycomponents- exported Vue component (that can only be used in a specific Vue version)core,componentsanduias npm package exportsvueand@nextcloud/vueas direct dependencies to allow installation in Vue 3 environmentDetailed explanation
Details