Added retry capability for uploading files

[Koc]

• Resolves Retry chunk if failed #5

You can observe how it works on the video below. I've tested library changes using npm link. For failure simulation I've added next snippet to remote.php:

	if ($_SERVER['REQUEST_METHOD'] === 'PUT' && random_int(0, 4) === 0) {
		throw new RemoteException('Service unavailable', 503);
	}

	sleep(2);

Also as you can see sha256 hash is the same for the uploaded and original files. So, files are not corrupted during retries. Later on we can configure how many retries available.

nextcloud-retry-upload.mp4

[susnux]

Probably we also need to retry folder creation of recursive uploads

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 22.52%. Comparing base (0ae7a81) to head (2571ef9).
Report is 346 commits behind head on main.

Files	Patch %	Lines
lib/uploader.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
+ Coverage   16.85%   22.52%   +5.66%     
==========================================
  Files           9       12       +3     
  Lines         445     2482    +2037     
  Branches       77       47      -30     
==========================================
+ Hits           75      559     +484     
- Misses        367     1923    +1556     
+ Partials        3        0       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Koc]

@susnux I will try to do that.

Any idea why Cypress is failing? How can I debug/fix that?

  0 passing (368ms)
  1 failing

  1) An uncaught error was detected outside of a test:
     TypeError: The following error originated from your test code, not from Cypress.

  > Failed to fetch dynamically imported module: http://localhost:5173/__cypress/src/@fs/home/runner/work/nextcloud-upload/nextcloud-upload/cypress/components/UploadPicker.cy.ts

[susnux]

Any idea why Cypress is failing? How can I debug/fix that?

Its flaky just needs to be restarted, known issue of Cypress (but if you dont pay money they do not care 😔 ).

[skjnldsv]

Any idea why Cypress is failing? How can I debug/fix that?

Its flaky just needs to be restarted, known issue of Cypress (but if you dont pay money they do not care 😔 ).

5 restarts and still failing? 🤔
Might actually be a bug?

[Koc]

@skjnldsv but it works on my machine 🤷

@susnux I've added retry for MKCOL as well. But seems like we should add retries for PROPFIND call (not in nextcloud-upload but in core)

[Koc]

maybe failure caused by adding of a new dependency. But I didn't get how to fix that by googling. Also as you can see from the video - it works on my machine.

cypress-local.mp4

Please help to debug it 🙏

Here more info cypress-io/cypress#25913

[susnux]

Yes this is that mentioned error, one long standing Cypress bug...

[Koc]

Thank you for merging 🤝

@susnux @skjnldsv can we bump a new version? Because I need integrate it into https://github.com/nextcloud/server as well

[susnux]

can we bump a new version?

Yes there is another feature we will release, so would schedule a release tomorrow or Thursday.