Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uploader): fix PUT content-type #1002

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(uploader): fix PUT content-type #1002

merged 1 commit into from
Dec 15, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Dec 15, 2023

Fix #995

PUT should not be application/x-www-form-urlencoded which axios do by default it seems.
Now we make sure to use the proper mime type for regular upload or application/octet-stream for chunks

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Dec 15, 2023
@skjnldsv skjnldsv self-assigned this Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (144c40d) 92.10% compared to head (2c613f0) 91.25%.
Report is 1 commits behind head on master.

Files Patch % Lines
lib/utils/upload.ts 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   92.10%   91.25%   -0.86%     
==========================================
  Files           3        3              
  Lines          76       80       +4     
  Branches       13       16       +3     
==========================================
+ Hits           70       73       +3     
- Misses          3        4       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the bug Something isn't working label Dec 15, 2023
@skjnldsv skjnldsv merged commit 5847d13 into master Dec 15, 2023
14 of 16 checks passed
@skjnldsv skjnldsv deleted the fix/content-type branch December 15, 2023 13:45
@skjnldsv
Copy link
Contributor Author

Merging for RC1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the right Content-Type
1 participant