fix: Files list loading with special chars in uid#759
Closed
Conversation
Pytal
added
type: bug
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
- Coverage 77.17% 76.98% -0.20%
==========================================
Files 17 17
Lines 403 404 +1
Branches 108 108
==========================================
Hits 311 311
- Misses 91 92 +1
Partials 1 1
📢 Have feedback on the report? Share it here. |
Pytal
changed the title
Signed-off-by: Christopher Ng <chrng8@gmail.com>
susnux
reviewed
Sep 24, 2023
| const client = createClient(remoteURL, { | ||
| // Encode valid user id characters | ||
| const encodedUrl = encodeURI(remoteURL) | ||
| .replaceAll('\'', '%27') |
Contributor
There was a problem hiding this comment.
Why replacing the quote here? It is valid for URI according to RFC.
Contributor
Author
|
Superseded by perry-mitchell/webdav-client#360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring nextcloud/server#40313 to lib